Shape Agnostic copyChunk2Array#704
Merged
Merged
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetCurrentArrayusescopyChunk2Arraywhich was originally vibe coded for 3D arrays. Since this is one of the few functions I have no idea what it's doing I went back to Claude and it suggested making it shape agnostic. I don't know how it works but it works. However, it requires the shape and strides to be the same and since strides is 2D in the chunk that is passed, I added a pruning map to the chunk saver to remove dims with a length of 1 from the shape.I feel like the .filter() could break logic at some point. But we will change that if/when it comes and I understand what the problem is.
closes #703