Skip to content

Reprojection TimeSeries#702

Merged
TheJeran merged 10 commits into
mainfrom
jp/reprojectionIntegration
Jul 22, 2026
Merged

Reprojection TimeSeries#702
TheJeran merged 10 commits into
mainfrom
jp/reprojectionIntegration

Conversation

@TheJeran

Copy link
Copy Markdown
Collaborator

This PR is to align the timeseries selections with reprojected data.

Basically just uses the UV from remapTexture to get the correct UV to sample the original array. Also to calculate the correct position for the timeseries meshes.

While playing around I realized that the UVCube should not be flipped for sampling from the array.

Lastly, updated UI to reflect the new Units/values of the reprojected Axis'

Map overlay

image

Slicer options

image

dimCoords

image

TODO

I would like to have the timeseries meshes change positions between reprojections, but I can't think of an elegant solution at the moment

Also, creating a time series along either the X or Y axis during reprojection will improperly show the time series for the entire extent of the CRS axis. I will need to create a new function that gets the UVs from row/column of the CRSTexture and then uses those to sample from the underlying data. But I will do that later

@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@TheJeran

Copy link
Copy Markdown
Collaborator Author

Noticed GetCurrentArray doen't work for 2D arrays atm. Will push a fix for that first. I haven't tested this PR on 2D data yet.

@TheJeran
TheJeran marked this pull request as ready for review July 22, 2026 13:16
@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@TheJeran

Copy link
Copy Markdown
Collaborator Author

Working on 2D data as well

@TheJeran
TheJeran merged commit 3d65b3d into main Jul 22, 2026
6 checks passed
@TheJeran
TheJeran deleted the jp/reprojectionIntegration branch July 22, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants