Reprojection TimeSeries#702
Merged
Merged
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Collaborator
Author
|
Noticed |
TheJeran
marked this pull request as ready for review
July 22, 2026 13:16
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Collaborator
Author
|
Working on 2D data as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to align the timeseries selections with reprojected data.
Basically just uses the UV from
remapTextureto get the correct UV to sample the original array. Also to calculate the correct position for the timeseries meshes.While playing around I realized that the
UVCubeshould not be flipped for sampling from the array.Lastly, updated UI to reflect the new Units/values of the reprojected Axis'
Map overlay
Slicer options
dimCoords
TODO
I would like to have the timeseries meshes change positions between reprojections, but I can't think of an elegant solution at the moment
Also, creating a time series along either the X or Y axis during reprojection will improperly show the time series for the entire extent of the CRS axis. I will need to create a new function that gets the UVs from row/column of the CRSTexture and then uses those to sample from the underlying data. But I will do that later