Allow planned orders to be added to another route group - #320
Merged
Merged
Conversation
Constraint: Saved plans may share real orders; each group's child routes still partition membership. Rejected: Allow in the list only | the submission action must apply the same candidate policy. Tested: 937 tests, build, typecheck, changed-file lint, public URL guard and synthetic browser selection. Not-tested: Full lint remains blocked by unchanged app.drivers-vehicles.jsx process/no-undef baseline. Scope-risk: narrow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add existing orders rejected #2324 as already assigned even when its existing plan belonged to another group. Candidate loading and the submission action now follow the server's duplicate-planning contract: foreign-group planned orders remain selectable, including Date Pending orders, while current-group child membership stays blocked.
Cancelled, completed, failed, skipped and missing-coordinate orders retain their existing restrictions. The existing server API remains authoritative for execution conflicts and revision checks.
Validation:
Server dependency EVNSolution/clever-route-server#480 is deployed at 8974e310c6d432595ea10df83e729bd6890a3240 with healthy runtime and public health check. Deploy this app manually to kfood only after exact-main CI, then verify #2324 in the authenticated Add existing orders UI without submitting a production addition.
Change control: EVNSolution/clever-change-control#309
Release verified: merged as 27749e3; exact-main CI 37044340258 and kfood deploy 37044459741 succeeded. Runtime image and release pointer match. After refresh, order #2324 appears Available, can be checked, and enables Add 1 in Sat 10/03 orders. The production addition was not submitted.