Skip to content

Keep route ETA cells numeric when estimates are missing - #319

Merged
OziinG merged 1 commit into
mainfrom
codex/kfood-eta-display-fix
Oct 2, 2026
Merged

OziinG merged 1 commit into
mainfrom
codex/kfood-eta-display-fix

Conversation

@OziinG

@OziinG OziinG commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Route ETA cells copied hidden “Planned ETA / Actual arrival” labels and displayed a missing planned marker above an observed arrival. Keep descriptive text in the accessible name and tooltip, display only numeric times, and show only the actual time when no estimate exists.

  • Validation: 932 tests, changed-file ESLint, typecheck, and build passed. Four rendering regressions failed before the fix and pass afterward; browser checks confirm numeric cell text and conditional strikethrough.
  • This preserves existing timestamps. Recovery of missing route geometry/ETA data is handled in the server follow-up.

Constraint: Reuse observed timestamps and never invent a missing planned ETA.
Rejected: Hidden label text inside time cells | Labels leaked into copied table text.
Confidence: high
Scope-risk: narrow
Tested: 932 tests; focused rendering regressions; changed-file lint; typecheck; build; browser cell text and strikethrough.
Not-tested: Production hotfix UI pending deployment.
@OziinG
OziinG merged commit 275dcbe into main Oct 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant