Find orders across delivery dates and show Start/End timing in route tables - #318
Merged
Merged
Conversation
Date-independent search includes Date Pending while keeping blocked orders visible and unselectable. Start and End share the existing numeric ETA presentation and preserve actual-time and saved-location evidence. Constraint: Stored order dates and route dates must not change during manual additions. Rejected: Visible Planned and Unconfirmed labels | Use planned strike-through with actual time beneath, matching stop rows. Confidence: high Scope-risk: moderate Tested: 928 app tests; scoped lint; typecheck; production build; synthetic browser checks for search, selection, endpoints, child and aggregate views. Not-tested: Production writes; full lint retains existing app.drivers-vehicles.jsx process no-undef at line 651.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Order searches all synchronized orders by number regardless of the selected delivery-date filter, including Date Pending. Orders that cannot be added remain visible with a reason and cannot enter individual or bulk selection; the action re-fetches eligible candidates before sending the request.
Standalone and child route tables now show Start first and End last in Stops and Tracking. Endpoint rows share the existing ETA presentation: a recorded actual time appears beneath a struck-through planned time; otherwise only the planned time or a dash appears. They do not affect stop counts, selection, or reordering, and no aggregate endpoints are added to All routes. End planning includes coherent drive, service, waiting and return timing. Actual times use recorded evidence, and saved depot labels are never silently replaced by a different current location.
Depends on server EVNSolution/clever-route-server#478 for cross-date additions and execution-evidence scoping. Release the server first.
Validation
Exact-head GitHub CI passed.
App suite: 928/928 passed; focused endpoint/search suite: 59/59 passed.
Changed-file ESLint, typecheck and production build passed.
Prisma migration replay, token-authority SDK contract and public URL checks passed.
Real RouteDetail component in a synthetic local browser fixture: Date Pending/cross-date search, disabled candidate reasons, eligible-only select all, numeric endpoint times in Stops/Tracking, child rows, and no aggregate Start/End rows confirmed. Maps and production transports are stubbed.
Independent review: no remaining findings.
Full lint has one pre-existing error in unchanged
app.drivers-vehicles.jsx:651(process/no-undef); the baseline contains the same line.No production deployment or order mutation performed. Toll roads remain research-only in the server PR.