Skip to content

Keep filter popovers and route detail layouts stable - #316

Merged
OziinG merged 1 commit into
mainfrom
codex/fix-filter-popover-jump
Oct 1, 2026
Merged

OziinG merged 1 commit into
mainfrom
codex/fix-filter-popover-jump

Conversation

@OziinG

@OziinG OziinG commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Closing or applying an Orders filter could scroll the embedded page to its trigger; reopening then placed the popover at a different screen position. Focus restoration now preserves scrolling, and applied/search chips plus Add filter retain their widths in narrow toolbars.

Route Detail renders map → timeline → order list for standalone and All routes views. Route Overview uses explicit label/value line heights and compact spacing; its four metrics remain in two columns down to 521px instead of prematurely stacking into one tall column. Map height and tracking data are unchanged.

Validation:

  • Real React/Polaris fixture reproduced a 381px close-induced jump; the same action retains its scroll position after the fix.
  • Automatic browser checks verify scrolling, keyboard focus restoration, search/active/Add filter widths: all seven pass at 636×560, 1000×360, and 636×760 iframe sizes. The previous release fails six checks.
  • Verified timeline precedes the order table for both route views; the moved timeline content is unchanged.
  • Overview checked at 390, 681, and 1440px; no horizontal overflow. At 681px its height is about 165px compared with the prior 288px. An 80-character driver name wraps at 521/681px while every metric retains its 4px label/value gap.
  • Integrated npm test passed (888 tests after rebasing onto the merged session authority change); targeted route tests passed (75). Build, typecheck, scoped ESLint and public URL guard passed. Exact-head CI repeats integrated validation. Independent review findings were addressed, including long driver labels.

Release via manual K-food deployment after exact-main CI and the existing server-first prerequisite from PR #315. No Shopify source records or delivery data are modified.

Preserve document scrolling when restoring filter focus and keep toolbar chips from overlapping. Place the route timeline before orders, and give Route Overview a compact responsive rhythm.

Confidence: high
Scope-risk: narrow
Tested: 867 app tests; browser focus and scroll regression at three iframe sizes; route order and Overview at desktop and mobile widths
Not-tested: Production UI verification follows manual K-food deployment
@OziinG
OziinG force-pushed the codex/fix-filter-popover-jump branch from e444f83 to 070793a Compare October 1, 2026 17:59
@OziinG
OziinG merged commit 84f4b0b into main Oct 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant