Restore order notes and consistent planning details in K-food - #314
Merged
Merged
Conversation
Preserve canonical notes and pending-date selection, show order details in every route scope, and stabilize embedded filter and session-token handling. Record the separate server cutoff and note projection defects with read-only evidence. Constraint: Shopify orders remain read-only and production is unchanged Rejected: Group-wide stop mutations from the new table | information display does not require expanding draft mutation scope Confidence: high Scope-risk: moderate Directive: Fix server ingestion cutoff and note projection before claiming the production incident resolved Tested: 867 app tests, 16 canonical tests, build, typecheck, public URL guard, changed-file lint, embedded fixture checks Not-tested: Production deployment and historical date repair
Match the canonical API note contract by distinguishing absent fields from explicit null clears. Record why the order-number note icon disappears and which customer-note ingestion work remains after the server release. Constraint: Preserve order and customer note meaning independently of delivery instructions Confidence: high Scope-risk: narrow Tested: 123 focused tests, typecheck, build, changed-file lint, independent review Not-tested: Production Shopify app deployment and customer-profile note ingestion
Constraint: Mocked fetch has no socket to keep Node alive for an unreferenced timeout. Confidence: high Scope-risk: narrow Tested: All 867 app tests and scoped ESLint pass; independent review approved. Directive: Assert the real TimeoutError so the fallback timer cannot mask a regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Orders with Shopify notes lost their note buttons when the canonical-only loader bypassed the Shopify query. Preserve order and customer note fields through the canonical adapter, including explicit clears from the server, so available notes appear beside the order number again.
The same operational fix also keeps filter popovers beside their triggers across repeated openings, exposes Date pending in Add Order, shows the existing order details in standalone and All routes views, and avoids reusing completed Shopify session tokens. All routes exposes read-only details and links to the owning route.
Validation:
Deployment: K-food only, after exact-main CI succeeds. Server PR EVNSolution/clever-route-server#470 is already deployed. Customer-profile note ingestion remains a server follow-up when no customer note exists in the canonical payload; this change does not invent or conflate delivery instructions with customer notes. Historical delivery dates and Shopify source records are unchanged.