docs(mac): update CIME machine configuration documentation for Darwin OS-level support - #5028
docs(mac): update CIME machine configuration documentation for Darwin OS-level support#5028johnpaulalex wants to merge 1 commit into
Conversation
billsacks
left a comment
There was a problem hiding this comment.
Thanks a lot for both this documentation and the changes to support it, @johnpaulalex !
|
@johnpaulalex - I see that there are conflicts with the latest version of this documentation. Please merge and resolve conflicts. It may be because of some recent work to remove machine-specific things from the documentation. @jasonb5 - any thoughts on whether this machine-specific documentation is appropriate here or if we want it elsewhere? |
02c46d2 to
d5d463e
Compare
|
Thanks Bill. I merged and resolved. Note these docs depend on ESMCI/ccs_config_cesm#298 which actually makes the darwin stuff work (I also added this pointer to the PR description). Is there some ordering to worry about here? |
|
Thanks, @johnpaulalex ! I'm happy with this, but I want to hear @jasonb5 's thoughts before merging. I'm not concerned about order dependency because this is just documentation, so it's not a big deal if it's temporarily out of sync. |
d5d463e to
59a6d09
Compare
|
Thanks @jasonb5 and @billsacks! I restored the paragraph, and put the Macos stuff below it. Also I removed the paragraph about homebrew sticking around - I meant to ask if homebrew is a config we should still keep around in general. Is it more generic than just Macs? |
|
A few comments: (1)
I think this is a question for the ccs_config changes, not really for this CIME documentation change. Do you agree? That said, I'll try to answer it: I haven't totally gotten my head around what you did for the ccs_config changes, but if you have made homebrew obsolete for Macs, then I think it can be removed. As far as I know, homebrew is only for Macs. (2) I see that you removed reference to CESM in your latest version. I actually think that CESM should be mentioned specifically there, because what you're describing is not generic CIME functionality, but (I think) depends on the changes you made in CESM's ccs_config. (3) A general GitHub process issue: I find it a lot easier to iteratively review PRs if they don't include force pushes – instead involving simple commits that build on each other. Maybe there's a solution I'm not aware of, but I don't know a good way to see what changed since my last review in the presence of force pushes, and this makes it harder for me to re-review changes. In a case like this one where the history of the branch isn't very important, I am okay with a final cleanup squash just before merging, but I prefer if the development in the midst of review doesn't include any force pushes that overwrite history. That said, I'm curious how others feel about this. Thanks a lot for continuing to iterate on this - I appreciate the care you're taking with this documentation! |
… OS-level support
59a6d09 to
f4a0ba9
Compare
|
Thanks Bill. I thought homebrew also applied to this PR because this seems like the natural place to have mentioned it (but now superseded by the Darwin instructions). Yeah I think the new changes supersede the old homebrew mechanism, and now require no special var-setting from users. I updated that PR to be clearer about what it's doing. I added CESM back to the text in this PR. And TIL about force-pushing being not good for reviews. Makes sense. I had kinda noticed that github wasn't showing diffs and I didn't connect the dots why. That said, it's a process of iterating with AI and even though I had instructed it to not force-push anymore, it just did it anyway for my CESM change above. Sigh. I updated my instructions again and I believe it won't happen again. |
billsacks
left a comment
There was a problem hiding this comment.
Thanks for your continued iteration on this! Looks good to me.
Ah, gotcha - I hadn't realized that you were referring to the documentation. I realize that it's confusing that we have documentation in CIME despite it documenting something that lives outside of CIME and is CESM-specific... we're still working on how to manage this... thanks for bearing with us.
Great!
Not a big deal here, but yes, thanks for trying to change this for the future - it would be more of a problem with larger PRs. |
Description of changes
Updates CIME machine configuration documentation (
cime/doc/source/ccs/model-configuration/support-a-new-machine.rst) to document zero-config macOS (Darwin) OS-level support and macro resolution in the CESM repository while preserving the model-independent machine configuration documentation.Specific notes
Contributors other than yourself, if any:
Linked issues addressed, if any:
Description of generative AI usage:
Answer Changes & Scientific Impact
User Interface & Namelist Changes
cime/doc/source/ccs/model-configuration/support-a-new-machine.rst)Testing planned or performed, if any:
CTSM / CESM baseline hash-tag:
8961a1142PR branch hash-tag:
f4a0ba9a1Requirements before merge: