Skip to content

All values passed for string option values (except for file names) are converted to lower case#3108

Open
jajhall wants to merge 1 commit into
latestfrom
fix-3107
Open

All values passed for string option values (except for file names) are converted to lower case#3108
jajhall wants to merge 1 commit into
latestfrom
fix-3107

Conversation

@jajhall

@jajhall jajhall commented Jun 28, 2026

Copy link
Copy Markdown
Member

Closes #3107

@odow

odow commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

The counter point to this is that you could accept only the case sensitive strings and error when something doesn't match? (Shouldn't that already be the case?)

@odow

odow commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator
julia> highs = Highs_create()
Ptr{Nothing}(0x0000000818ef0000)

julia> Highs_setStringOptionValue(highs, "parallel", "On")
ERROR:   Value "On" for parallel option is not one of "off", "choose" or "on"
-1

Seems good to me... I wonder why the OP didn't realise in #3106?

@jajhall

jajhall commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

That's what was done before - other than strings for bool options - but today someone used "On", not "on" for the parallel option. He and I both lost time trying to work out what happened.

Of course he didn't check the HighsStatus::kError return 🙄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants