Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #3097 +/- ##
==========================================
+ Coverage 73.11% 73.16% +0.05%
==========================================
Files 431 430 -1
Lines 103801 104118 +317
Branches 16712 16765 +53
==========================================
+ Hits 75892 76181 +289
- Misses 27633 27661 +28
Partials 276 276 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements an iterative form of tarjans algorithm that traverses the clique table and tries to find strongly connected component, e.g. a proof that
x = y = ~z, as well as infeasible assignments, e.g.,x -> y -> ~x => x can't be true.It is first mentioned in Mixed integer programming: Analyzing 12 years of progress, albeit some improvements of the algorithm are intentionally not described in depth. The implementation is largely copied from SCIP 5.0, where it gave a ~2% performance improvement (only getting ~0.2% on my smaller test set)
Some notes:
HighsDomainandHighsCliqueTable, which will then be applied infinaliseProbing@fwesselm No rush to review this. I'd rather attention is on #2990 first.