[G2M] fasttext - load wasm from disk on Node 22+ - #68
Merged
Merged
Conversation
|
👋 Hello! I couldn't find a Notion Task URL in the PR description. Please add the full Notion Task URL to the PR body so I can keep everything in sync! ✨ (If you've already added it, please ensure it's a valid Notion URL.) |
Member
Author
|
I forgot to add a reviewer and pushed/merged changes to main but haven't released it yet @amy83762100 , can i proceed with a release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@eqworks/releaseloadsfasttext.jsas soon as the CLI starts, to classify commit subjects. That package's WebAssembly loader callsfetch()on a filesystem path wheneverWebAssembly.instantiateStreamingexists. Node 22 and later always havefetch, and they reject a raw path (TypeError: Failed to parse URL), then the loader aborts the process (exit code 7). This is what broke release-notes generation in clearlake2 after Node was bumped to 24. The oldNODE_OPTIONS=--no-experimental-fetchworkaround is invalid on those versions, so Node exits before the CLI runs.lib/utils.jsnow removesWebAssembly.instantiateStreamingbefore requiringfasttext.js. The loader then readsfasttext_wasm.wasmfrom disk, which is the path it already had for Node. Classification still works. The README no longer tells people to set the fetch flag.Version is
3.5.4. Merging to main lets the existing tag job cutv3.5.4, which publishes to npm and GitHub Packages.