Skip to content

[G2M] fasttext - load wasm from disk on Node 22+ - #68

Merged
ashishjullia merged 2 commits into
mainfrom
fasttext-wasm-node
Sep 25, 2026
Merged

ashishjullia merged 2 commits into
mainfrom
fasttext-wasm-node

Conversation

@ashishjullia

Copy link
Copy Markdown
Member

Summary

@eqworks/release loads fasttext.js as soon as the CLI starts, to classify commit subjects. That package's WebAssembly loader calls fetch() on a filesystem path whenever WebAssembly.instantiateStreaming exists. Node 22 and later always have fetch, and they reject a raw path (TypeError: Failed to parse URL), then the loader aborts the process (exit code 7). This is what broke release-notes generation in clearlake2 after Node was bumped to 24. The old NODE_OPTIONS=--no-experimental-fetch workaround is invalid on those versions, so Node exits before the CLI runs.

lib/utils.js now removes WebAssembly.instantiateStreaming before requiring fasttext.js. The loader then reads fasttext_wasm.wasm from disk, which is the path it already had for Node. Classification still works. The README no longer tells people to set the fetch flag.

Version is 3.5.4. Merging to main lets the existing tag job cut v3.5.4, which publishes to npm and GitHub Packages.

@eq-gh-notion-integration-prod

Copy link
Copy Markdown

👋 Hello! I couldn't find a Notion Task URL in the PR description. Please add the full Notion Task URL to the PR body so I can keep everything in sync! ✨

(If you've already added it, please ensure it's a valid Notion URL.)

@ashishjullia
ashishjullia merged commit dfec7c4 into main Sep 25, 2026
5 of 9 checks passed
@ashishjullia

Copy link
Copy Markdown
Member Author

I forgot to add a reviewer and pushed/merged changes to main but haven't released it yet @amy83762100 , can i proceed with a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant