Repository navigation
fix: consistent spatial chunking for Sentinel-2 multiscales - #331
Merged
Merged
Conversation
Contributor
Security Audit ReportBandit — Static Security Analysis (Security tab)12 issue(s) found: 1 medium, 11 low ✅ No issues at or above HIGH severity. 1 medium, 11 low issue(s) below threshold not shown in table. pip-audit — Dependency Vulnerabilities (Security tab)Dependencies audited: 121, skipped: 0.
3 vulnerability/vulnerabilities found (3 fixable) across 1 package(s). Result: ❌ Blocking issues found — see details above. |
claxn
marked this pull request as ready for review
October 28, 2026 23:40
d-v-b
approved these changes
Oct 29, 2026
lhoupert
approved these changes
Oct 29, 2026
Clears CVE-2026-116577, CVE-2026-115927 and CVE-2026-116578, which block the pip-audit security check.
claxn
force-pushed
the
fix/consistent-ms-chunking
branch
from
October 29, 2026 12:06
cdd2bb7 to
4a35d85
Compare
d-v-b
added a commit
to d-v-b/data-model
that referenced
this pull request
Oct 29, 2026
…to feat/pydantic-zarr-scoped-validation Resolves the conflicts between this branch's plan-driven S2 pipeline and upstream's root-consolidation harmonization (EOPF-Explorer#328) and spatial-chunking fix (EOPF-Explorer#331): - convert_s2_optimized now feeds the planned dataset index into the harmonized utils.updated_root_consolidation, passing the plan's None-mapped multiscale roots as additional_consolidate_paths; the converter-local simple_root_consolidation, add_multiscale_pyramids_to_stac_metadata and write_store_root_bbox are gone, and add_s2_stac_assets (from EOPF-Explorer#328) is adapted to take the index and the planned reflectance shape. - utils.add_multiscale_pyramids_to_stac_metadata accepts a dataset's variable names in place of the dataset, which is what the plan-driven converter has. - convert_s2 and the DataTree-writer code EOPF-Explorer#328/EOPF-Explorer#331 touched stay deleted (no remaining callers); max_retries leaves convert_s2_optimized as upstream removed it from the call sites. - tests follow: the consolidation tests run against updated_root_consolidation with explicit None roots, upstream's revived test_s2_multiscale_geo_metadata (now against conversion.utils) is kept, and the DataTree-writer tests stay deleted. - uv.lock re-locked: upstream's bumps plus this branch's pinned pydantic-zarr commit; the regenerated plan snapshots are byte-identical to the merged files, so both pipelines had converged on the same output. Assisted-by: ClaudeCode:claude-fable-5 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this fix, the desired spatial chunking (e.g. 1024) was not applied on Sentinel-2 multiscaled arrays, only on native ones. Now
generic_multiscalesapplies thespatial_chunkparameter consistently to all arrays. This PR is meant to be stacked on #328.