Fast mseed metadata#45
Open
raciner wants to merge 2 commits into
Open
Conversation
Contributor
|
I'm not sure if there is an official maintainer of this project ? If yes could he/she merge this PR ? |
Contributor
|
I think it is already in the master branch somehow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We discovered that WFCatalogCollector.py is very slow and memory inefficient for large files containing data with high sampling rates. Using a memory profiler, I narrowed it down to metadata = MSEEDMetadata(...) and from there to
self.meta['sample_rms'] = \ np.sqrt(sum((tr.data.astype(object) ** 2).sum() for tr in self.data) / npts)in obspy/signal/quality_control.py
The proposed code introduces a new subclass FastMSEEDMetadata which replaces obspy.signal.MSEEDMetadata. It replaces the method identified as problematic with verctorised numpy code which should yield the exact same values within numerical error.