added IAsyncEnumerable support to IncludableExpressiveQueryableWrapper#72
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enables async terminal EF Core operations (e.g., ToListAsync, ToArrayAsync) on Include/ThenInclude chains built from expressive query sources by making the includable wrapper async-enumerable, and adds integration tests covering the scenario.
Changes:
- Implemented
IAsyncEnumerable<TEntity>onIncludableExpressiveQueryableWrapper<TEntity, TProperty>by delegating async enumeration to the underlying EF Core query. - Added integration tests validating
Include(...).ToListAsync(),Include(...).ToArrayAsync(), andInclude(...).ThenInclude(...).ToListAsync()onContext.ExpressiveOrders.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/ExpressiveSharp.EntityFrameworkCore.IntegrationTests/Infrastructure/AsyncQueryableTestBase.cs | Adds integration tests for async terminal operations after Include/ThenInclude on expressive queries. |
| src/ExpressiveSharp.EntityFrameworkCore/Infrastructure/IncludableExpressiveQueryableWrapper.cs | Adds IAsyncEnumerable<TEntity> support so EF Core async terminal methods can enumerate includable expressive queries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+121
to
+123
| public async Task Include_ToListAsync_DirectTerminal_LoadsNavigation() | ||
| { | ||
| var results = await Context.ExpressiveOrders |
Comment on lines
+132
to
+134
| public async Task Include_ToArrayAsync_DirectTerminal_LoadsNavigation() | ||
| { | ||
| var results = await Context.ExpressiveOrders |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
query.Include(x => x.Foo).ToListAsync()was unavailable as IncludableExpressiveQueryableWrapper did not implement IAsyncEnumerable