fix: close remaining SCP action gaps and expire cached Wiz webhook secret - #17
Merged
Merged
Conversation
…cret - scp-guardrails: deny-disable-security-services now also denies the current-name GuardDuty/Security Hub administrator-disassociation actions (the legacy ...FromMasterAccount names are distinct IAM actions), guardduty:DeleteMembers/StopMonitoringMembers and securityhub:BatchDisableStandards/DeleteMembers/DisassociateMembers/ DisableOrganizationAdminAccount. Applied to the policy JSON, the CloudFormation template and the Terraform module; README documents the new break-glass implication. - wiz-finding-bridge: the webhook secret cache now expires after SECRET_CACHE_TTL_SECONDS (default 300), so a rotated token stops being accepted within minutes instead of persisting in warm execution environments; a failed refresh no longer keeps serving the stale value. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to a source review of the toolbox. Most findings were already fixed on
mainby #15; this covers what remained.scp-guardrails/deny-disable-security-services: also deny the current-name GuardDuty and Security Hub administrator-disassociation actions (...FromAdministratorAccount; the legacy...FromMasterAccountnames are separate IAM actions), plusguardduty:DeleteMembers/StopMonitoringMembersandsecurityhub:BatchDisableStandards/DeleteMembers/DisassociateMembers/DisableOrganizationAdminAccount. Applied to the policy JSON, the CloudFormation template and the Terraform module. All action names were checked against AWS's published service reference. README documents that membership/standards changes now need an exempted role.wiz-finding-bridge: the webhook secret cache now expires afterSECRET_CACHE_TTL_SECONDS(default 300). Previously a rotated token kept being accepted by warm Lambda containers until they were recycled. A failed refresh no longer keeps serving the stale value. Both Lambda copies remain identical; READMEs gain a rotation note.Testing
terraform fmt -check -recursive terraformpasses; policy JSON and CFN SCP literals parse.cfn-lint, Checkov,terraform validate(not installed) - relying on CI.Notes