Skip to content

feat: workspace rename with inline edit pen icon - #50

Merged
Dunkrick merged 4 commits into
mainfrom
redesign/rename-workspace
Nov 9, 2026
Merged

Dunkrick merged 4 commits into
mainfrom
redesign/rename-workspace

Conversation

@Dunkrick

@Dunkrick Dunkrick commented Nov 9, 2026

Copy link
Copy Markdown
Owner

Summary

Allows users to rename any workspace directly from the workspace switcher dropdown in the toolbar, with an inline edit form and pen icon button.

Decisions & Rationale

  • Owner-verified backend update (PATCH /workspaces/:id): Validates non-empty names and strictly verifies ownerId === userId to prevent unauthorized renaming.
  • Inline editing in switcher: Clicking the pen icon transforms that workspace item into an inline input without leaving the canvas.
  • Square pen icon button (--radius-0): Matches the square handle rule and uses tokenized border/colors with an accessible aria-label.
  • Keyboard accessibility: Supports Enter to save, Escape to cancel, and visible :focus-visible styling.

Verification

  • npm run lint (frontend) — passed (0 errors)
  • npm run build (frontend) — passed
  • npm test -- --run (frontend) — 8/8 files passed (66/66 tests)
  • npm run typecheck (backend) — passed (0 errors)
  • npm test (backend) — 13/13 files passed (85/85 tests)

- Add updateWorkspace service with owner-level authorization
- Add validateUpdateWorkspace validation middleware
- Expose authenticated PATCH /:id endpoint
- Add unit tests for workspace service and validation
- Add updateWorkspace API client call
- Add handleRenameWorkspace to Home page state handler
- Pass onRenameWorkspace through FloatingToolbar
- Add inline rename form and rename action to WorkspaceSwitcher
- Style switcher items, actions, and form inputs with design tokens
- Add component unit tests for switcher selection and renaming
- Render inline SVG pen icon inside workspace switcher action button
- Style action as a 24x24 square icon button with --radius-0
- Retain accessible aria-label and tooltip on button
@vercel

vercel Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nook Ready Ready Preview Nov 9, 2026 5:16pm UTC

@Dunkrick
Dunkrick merged commit 66e1e24 into main Nov 9, 2026
2 checks passed
@Dunkrick
Dunkrick deleted the redesign/rename-workspace branch November 9, 2026 17:18

This branch was successfully deployed

1 active deployment
Preview — 98c7f8d7 Deployed Nov 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant