Repository navigation
feat: workspace rename with inline edit pen icon - #50
Merged
Merged
Conversation
- Add updateWorkspace service with owner-level authorization - Add validateUpdateWorkspace validation middleware - Expose authenticated PATCH /:id endpoint - Add unit tests for workspace service and validation
- Add updateWorkspace API client call - Add handleRenameWorkspace to Home page state handler - Pass onRenameWorkspace through FloatingToolbar
- Add inline rename form and rename action to WorkspaceSwitcher - Style switcher items, actions, and form inputs with design tokens - Add component unit tests for switcher selection and renaming
- Render inline SVG pen icon inside workspace switcher action button - Style action as a 24x24 square icon button with --radius-0 - Retain accessible aria-label and tooltip on button
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allows users to rename any workspace directly from the workspace switcher dropdown in the toolbar, with an inline edit form and pen icon button.
Decisions & Rationale
PATCH /workspaces/:id): Validates non-empty names and strictly verifiesownerId === userIdto prevent unauthorized renaming.--radius-0): Matches the square handle rule and uses tokenized border/colors with an accessiblearia-label.Enterto save,Escapeto cancel, and visible:focus-visiblestyling.Verification
npm run lint(frontend) — passed (0 errors)npm run build(frontend) — passednpm test -- --run(frontend) — 8/8 files passed (66/66 tests)npm run typecheck(backend) — passed (0 errors)npm test(backend) — 13/13 files passed (85/85 tests)