Repository navigation
Redesign/centralized color picker - #42
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request unifies canvas interaction, paper stock personalization, and authentication ergonomics across the Nook frontend:
--cursor-spatial) for the spatial canvas and corkboard, engineered with dual-stroke contrast for visibility across all surfaces.Story of Changes
1. Centralized Paper Stock Dashboard (
ColorDashboard.tsx,overlays.css,Home.tsx)ArtifactHeader.tsx,ArtifactActions.tsx,TintPicker.tsx), allowing notes to look clean and uninterrupted..nook-color-dashboard) displaying all seven paper stocks (Default, Cream, Rose, Sky, Sage, Lavender, Butter).translate(2px, -1px)with hard ink drop shadow2px 2px 0 var(--palette-ink)).translate(1px, 1px)with zero shadow)..nook-color-dashboard__swatch-mark) per design rule 9.ArrowUp/ArrowDownnavigation across swatches.transition: background-color var(--motion-settle)inartifact.cssso thought cards glide smoothly into their new paper stock.2. Canvas Vector Delta Cursor (
interaction.css,workspace.css)#17141Fink fill, backed by a subtle contrast shadow border (stroke-opacity="0.3" stroke-width="3.2") so the pointer remains crisp over light paper, grid dots, and dark cards.(2, 2)matching the northwest tip.3. Insight Panel Living Status (
InsightPanel.tsx,overlays.css).nook-insight-panel__working) featuring a lit beacon dot (.nook-insight-panel__beacon) pulsing invar(--accent-action).font-family: var(--font-mono), bold uppercase tracking, and paper backing.@media (prefers-reduced-motion: reduce)fallback to freeze the pulse smoothly.4. Side-by-Side OAuth Login (
AuthForm.tsx,auth.css)grid-template-columns: 1fr 1fr; gap: var(--space-3))."Continue with Google","Continue with GitHub"), displaying centered 20px vector brand marks.aria-labelandtitleattributes on both anchor links.5. Documentation & Interaction Spec
README.md,CHANGELOG.md(v1.3.0),docs/architecture.md,docs/setup.md, anddocs/design-system/interaction.md.Decisions and Reasons
--radius-0, hard ink shadows, standard spacing, and semantically mapped palette roles).Verification Results
Frontend
npm run lint— Clean (0 errors, 0 warnings).npm run build—tsc -b && vite buildbuilt successfully in 109ms.npm test -- --run— 7 test files passed, 52/52 tests passed:ColorDashboard.test.tsx(7 tests)InsightPanel.test.tsx(2 tests)PolaroidArtifactBody.test.tsx(23 tests)PolaroidDraft.test.tsx(7 tests)TintPicker.test.tsx(4 tests)UseArtifactEditing.test.ts(6 tests)canvas.test.ts(3 tests)grep -rnE "#[0-9a-fA-F]{3,8}\b" src/assets/styles --include="*.css" | grep -v "/tokens/"returned 0 violations.Backend
npm run typecheck—tsc --noEmitpassed with 0 errors.npm test— 11 test files passed, 76/76 tests passed.