Skip to content

Close settings modal on save #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DukeManh merged 1 commit into from
Nov 24, 2025
Merged

Close settings modal on save #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions js/settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ export function initSettings() {
// Get DOM elements
settingsModal = document.getElementById('settingsModal');
closeModalBtn = settingsModal.querySelector('.close-modal');

const saveSettingsBtn = document.getElementById('saveSettingsBtn');

// Get settings button
const settingsBtn = document.getElementById('settingsBtn');
Expand All @@ -56,6 +58,10 @@ export function initSettings() {
// Add event listeners
settingsBtn.addEventListener('click', openSettings);
closeModalBtn.addEventListener('click', closeSettings);
saveSettingsBtn?.addEventListener('click', async () => {
await autoSaveSettings();
closeSettings();
});

// Add event listeners for auto-save functionality
const presetRadios = document.querySelectorAll('input[name="timer-preset"]');
Expand Down