Use procedural macros to implement manually_traced types#22
Merged
Conversation
Techcable
marked this pull request as ready for review
January 22, 2021 04:43
Techcable
marked this pull request as draft
January 22, 2021 04:45
Member
Author
|
Wait it's still buggy - |
Techcable
force-pushed
the
refactor/better-macros
branch
from
January 22, 2021 23:54
b4f9baf to
9c06bbd
Compare
Procedural macros are more flexible and will allow us to use a single macro for all our manually traced code. It should also help downstream crates start to utilize this.
This is incomplete, but pretty darn awesome The core crate now depends on zerogc-derive and syn-full
This procedural derive is **much** cleaner (although it brings in all of syn as a dependency)
This is the proc-macro equivelant of '$crate'
Before the macors weren't recursing properly, so we only implemented it for 9-argument tuples ^_^ Add a test to verify that varius `core` types actually implement `Trace` properly. Unfortunately, the tests don't compile :(
Again, this is a problem with macro recursion ^_^
Techcable
force-pushed
the
refactor/better-macros
branch
from
January 23, 2021 06:06
9c06bbd to
2785d75
Compare
Techcable
marked this pull request as ready for review
January 23, 2021 06:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Procedural macros are more flexible and will allow us to use a
single macro for all our manually traced code.
It should also help downstream crates start to utilize this.
I'm doing this cleanup first because It makes implementing #20 much easier