Skip to content

fix: patch login sounds and update to v5.3.1 #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DuckBoss merged 4 commits into from
Jun 24, 2026
Merged

fix: patch login sounds and update to v5.3.1 #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad249ba
fix(plugin): resolved file discovery issue with user connection sounds
DuckBoss Jun 24, 2026
b54b35e
chore: bumped version to v5.3.1
DuckBoss Jun 24, 2026
21b9e8d
wiki: updated wiki for v5.3.1
DuckBoss Jun 24, 2026
c631664
docs: updated changelog for v5.3.1
DuckBoss Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
## JJMumbleBot v5.3.1 - Login sounds fixes
<b>This project is no longer under active development, and the bot is being reworked in the following rework project: [Mumimo](https://github.com/DuckBoss/Mumimo)</b>
However, I still use this older version of the bot and try to fix bugs when I find them, so here it is.

### Fixes
- <b>Server Tools Plugin</b>:
- Fixed login/user-connection sounds: The feature to play a 'connection sound' when a user connects to the server is
fixed with this update. You should now be able to set login sounds and it should play when the user connects to the server as it used to work before.

## JJMumbleBot v5.3.0 - New features and fixes

<b>This project is no longer under active development, and the bot is being reworked in the following rework project: [Mumimo](https://github.com/DuckBoss/Mumimo)</b>
Expand Down
2 changes: 1 addition & 1 deletion JJMumbleBot/lib/resources/strings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,5 +129,5 @@
###########################################################################
# BOT META INFORMATION STRINGS
META_NAME = "JJMumbleBot"
META_VERSION = "5.3.0"
META_VERSION = "5.3.1"
###########################################################################
2 changes: 1 addition & 1 deletion JJMumbleBot/plugins/core/server_tools/metadata.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[Plugin Information]
PluginVersion = 5.3.0
PluginVersion = 5.3.1
PluginName = Server Tools
PluginDescription = The Server Tools plugin is a miscellaneous collection of callbacks that are automatically executed on server events.
PluginLanguage = EN
Expand Down
15 changes: 9 additions & 6 deletions JJMumbleBot/plugins/core/server_tools/server_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,13 +131,15 @@ def util_find_sb_file(self, file_name):
return None

def util_find_and_create_track(self, file_name) -> Union[TrackInfo, None]:
file_track = None
if self.metadata.getboolean(
C_PLUGIN_SET, P_USE_SOUNDBOARD_CLIPS, fallback=True
):
if self.util_find_sb_file(file_name):
file_track = self.util_find_sb_file(file_name)
if file_track is not None:
return TrackInfo(
uri=f"{get_perm_med_dir()}/sound_board/{file_name}",
alt_uri=f"{get_perm_med_dir()}/sound_board/{file_name}",
uri=f"{get_perm_med_dir()}/sound_board/{file_track}",
alt_uri=f"{get_perm_med_dir()}/sound_board/{file_track}",
name=file_name,
sender=get_bot_name(),
duration=None,
Expand All @@ -146,10 +148,11 @@ def util_find_and_create_track(self, file_name) -> Union[TrackInfo, None]:
)
return None
else:
if self.util_find_file(file_name):
file_track = self.util_find_file(file_name)
if file_track is not None:
return TrackInfo(
uri=f"{get_perm_med_dir()}/{self.plugin_name}/{file_name}",
alt_uri=f"{get_perm_med_dir()}/{self.plugin_name}/{file_name}",
uri=f"{get_perm_med_dir()}/{self.plugin_name}/{file_track}",
alt_uri=f"{get_perm_med_dir()}/{self.plugin_name}/{file_track}",
name=file_name,
sender=get_bot_name(),
duration=None,
Expand Down
24 changes: 21 additions & 3 deletions docs/wiki/new/whats_new.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="UTF-8">
<title>JJMumbleBot - What's New [v5.3.0]</title>
<title>JJMumbleBot - What's New [v5.3.1]</title>
<noscript>Please enable JavaScript in your browser!</noscript>
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/bootswatch@4.5.2/dist/lux/bootstrap.min.css" crossorigin="anonymous">
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js"></script>
Expand All @@ -12,12 +12,28 @@
<body>
<nav id="table_of_contents"></nav>
<div class="main-content">
<h2 id="page-title"><small><b>v</b></small>5.3.1 Update</h2>
<h4>Fixes</h4>
<h6><a href="https://github.com/DuckBoss/JJMumbleBot/releases/tag/v5.3.1">Github Download Link</a></h6>
<hr/>
<div class="update-details">
<details>
<summary class="unselectable">Fixed user connection sounds <b class="update-details-header btn-success small">FIXES</b></summary>
<ul>
<li>
Fixed login/user-connection sounds: The feature to play a 'connection sound' when a user connects to the server is
fixed with this update. You should now be able to set login sounds and it should play when the user connects to the server as it used to work before.
</li>
</ul>
</details>
</div>
<br/>
<h2 id="page-title"><small><b>v</b></small>5.3.0 Update</h2>
<h4>New Features and Fixes</h4>
<h6><a href="https://github.com/DuckBoss/JJMumbleBot/releases/tag/v5.3.0">Github Download Link</a></h6>
<hr/>
<div class="update-guide alert alert-dismissible alert-warning">
<h5>Update Guide To v5.3.0 For <small><b>v</b></small>5.2.0 Users</h5>
<h5>Update Guide To v5.3.0+ For <small><b>v</b></small>5.2.0 Users</h5>

<details>
<summary class="unselectable">Click Here To View Guide</summary>
Expand All @@ -36,7 +52,7 @@ <h5>Update Guide To v5.3.0 For <small><b>v</b></small>5.2.0 Users</h5>
</details>
</div>
<div class="update-guide alert alert-dismissible alert-warning">
<h5>Update Guide To v5.3.0 For <small><b>v</b></small>5.1.0 and <small><b>v</b></small>5.1.1 Users</h5>
<h5>Update Guide To v5.3.0+ For <small><b>v</b></small>5.1.0 and <small><b>v</b></small>5.1.1 Users</h5>

<details>
<summary class="unselectable">Click Here To View Guide</summary>
Expand Down Expand Up @@ -165,6 +181,8 @@ <h5>Update Guide To v5.3.0 For <small><b>v</b></small>5.1.0 and <small><b>v</b><
The feature to play a 'connection sound' when a user connects to the server is currently broken.
<br>I highly suggest not using this feature. I don't plan on fixing it in this project and I will be addressing it in the larger rework project 'Mumimo'.
<br>If you still decide to use it and the audio queue freezes, simply use !stop to flush the audio queue.
<br>
<b>UPDATE: This has been resolved in v5.3.1+</b>
</p>
<p>
<b>Text to Speech Plugin</b>:
Expand Down
Loading