Deploy the site through Actions instead of the legacy build - #7
Merged
Conversation
The legacy branch build has failed on every push since 6 August: three in a row, on commits that touched only workflow files, each with a duration of zero and no log beyond "Page build failed". Nothing about it can be diagnosed from the outside, and it notifies nobody, so the site has been one content commit away from silently not shipping. Deploying through Actions gives the build a log, a status check and a failure notification. The artefact is also assembled by name rather than by copying the repository, so scripts/ and README.md stop being served as part of the site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The site has not deployed since 5 August. The legacy Pages build has failed on the last three pushes —
e8aa3ac,39c94af,58f748f— each withduration: 0and no log beyondPage build failed. All three touched only workflow files, so nothing user-visible has been lost yet; the next commit toindex.htmlwould have been.The GitHub API confirms it:
A legacy build cannot be diagnosed — there is no log — and it notifies nobody when it breaks.
What this changes
Deployment moves to Actions: a real build with a log, a status check on the commit, and a failure notification.
The artefact is also assembled by name rather than by copying the repository, so
scripts/andREADME.mdstop being served as part of the site. A new top-level directory now has to be added to the workflow deliberately instead of being published because it happened to exist.After merging
Pages must be switched from branch-based to Actions in the repository settings, or via:
Until that switch, the legacy build stays authoritative and keeps failing.