Skip to content

feat: hide join/quit message for vanished players#78

Open
NgLoader wants to merge 1 commit into
DrexHD:mainfrom
NgLoader:feat-hide-join-quit-mesage
Open

feat: hide join/quit message for vanished players#78
NgLoader wants to merge 1 commit into
DrexHD:mainfrom
NgLoader:feat-hide-join-quit-mesage

Conversation

@NgLoader

@NgLoader NgLoader commented Nov 23, 2025

Copy link
Copy Markdown
Contributor

Make it possible to disable the join/quit messages for vanished players.
It’s currently possible to suppress the join and quit message when toggling vanish, but not the actual join/quit messages.

@DrexHD

DrexHD commented Nov 28, 2025

Copy link
Copy Markdown
Owner

What would be the use case for this? These messages are only sent to players that can see the other vanished players anyways!

@NgLoader

NgLoader commented Nov 28, 2025

Copy link
Copy Markdown
Contributor Author

Yea, but what if you use the Vanish mod just as an api?

The hidden join/quit message is a nice feature but not everyone needs this.

Even that the default join and leave message can be toggle but not for vanished players.

@DrexHD

DrexHD commented Nov 28, 2025

Copy link
Copy Markdown
Owner

What is your API usecase? At the moment there isn't much API to use vanish, but more-so to add compat with vanish!

@NgLoader

NgLoader commented Nov 28, 2025

Copy link
Copy Markdown
Contributor Author

We're currently using the vanish mod api for our own system, which handle players, spectator and vanished players.

With the current implementation everything works fine but it always prints a join message, even when there isn't one.

If this is not the goal of the project I can compile a custom version for my server.
I just wanna add some more custimization for API only usage.

What do you thing of a boolen like "api-only: true" to toggle something like that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants