fix: improve play/pause behavior on desktop#986
Open
alexmello735-del wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Changed the GestureDetector on video_player_controls.dart:
Issue Being Fixed
Before, play/pause on click would not register if mouse was still moving when the click event triggered. But mouse movement is to be expected when quickly switching screens/windows, etc.
Resolves #580
Screenshots / Recordings
old: play/pause fails when mouse moving
old.2.mp4
new: play/pause works with mouse moving
new.2.mp4
Tested On
Checklist