Skip to content

Add egcloud.id custom-domain template#1426

Merged
pawel-kow merged 3 commits into
Domain-Connect:masterfrom
friza13:master
Jul 19, 2026
Merged

Add egcloud.id custom-domain template#1426
pawel-kow merged 3 commits into
Domain-Connect:masterfrom
friza13:master

Conversation

@friza13

@friza13 friza13 commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Description

Online Editor test results

Template tested with Domain Connect Online Editor:

Test egcloud.id/custom-domain example.com/app

Test scenarios:

  • Subdomain (app.example.com): PASS — records generated correctly
  • Apex (empty host): Correctly rejected with Template requires a host name (per hostRequired: true)

Note on logoUrl checkbox

Template intentionally omits logoUrl field. The checkbox resource URL provided with logoUrl is actually served by a webserver is checked because the requirement is vacuously true — there is no logoUrl in the template to serve. Logo will be added in a future template version once hosted at https://egcloud.id/logo.svg.

Type of change

Please mark options that are relevant.

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

Please mark the following checks done

  • Template functionality checked using Online Editor
  • Template file name follows the pattern <providerId>.<serviceId>.json
  • resource URL provided with logoUrl is actually served by a webserver

Checklist of common problems

Mark all the checkboxes after conducting the check. Comment on any point which is not fulfilled.
See Template Quality Guidelines for details and rationale on each rule.

  • syncPubKeyDomain is set — this is mandatory; omitting it requires explicit justification in the PR description or the PR will be rejected
  • warnPhishing is not set alongside syncPubKeyDomain — the two must not appear together
  • syncRedirectDomain is set whenever the template uses redirect_uri in the synchronous flow
  • no TXT record contains SPF content ("v=spf1 ...") — use the SPFM record type instead
  • txtConflictMatchingMode is set on every TXT record that must be unique per label or content prefix (e.g. DMARC)
  • no variable is used as a bare full record value (e.g. @ TXT "%foo%") unless necessary — prefer @ TXT "service-foo=%foo%"; if bare, justify in the PR description
  • no bare variable is used as the full host label — the non-variable parts are fixed to limit misuse (e.g. %dkimkey%._domainkey, not %dkimhost%); if bare, justify in the PR description
  • no variable is used in the host field to create a subdomain — use the host parameter or multiInstance instead
  • %host% does not appear explicitly in any host attribute
  • essential is set to OnApply on records the end user may need to modify or remove without breaking the template (e.g. DMARC)

Online Editor test results

Editor test link(s):

@github-actions github-actions Bot added Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. Test links missing No test links from Online Editor provided labels Jul 19, 2026
@github-actions

Copy link
Copy Markdown

JSON Filename Check Passed

@github-actions

github-actions Bot commented Jul 19, 2026

Copy link
Copy Markdown

JSON Schema Validation Passed

@github-actions github-actions Bot added the schema-error JSON Schema validation failed label Jul 19, 2026
@github-actions

github-actions Bot commented Jul 19, 2026

Copy link
Copy Markdown

Linter OK

egcloud.id.custom-domain.json

Level Code Note
info DCTL1021 missing from iana definitions

@github-actions github-actions Bot removed the Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. label Jul 19, 2026
@friza13 friza13 closed this Jul 19, 2026
@friza13 friza13 reopened this Jul 19, 2026
@friza13 friza13 closed this Jul 19, 2026
@friza13 friza13 reopened this Jul 19, 2026
@github-actions github-actions Bot added hostRequired hostRequired is set and removed Test links missing No test links from Online Editor provided schema-error JSON Schema validation failed labels Jul 19, 2026
@github-actions github-actions Bot added Test links missing No test links from Online Editor provided and removed Test links missing No test links from Online Editor provided labels Jul 19, 2026
@friza13 friza13 closed this Jul 19, 2026
@github-actions github-actions Bot removed the PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. label Jul 19, 2026
@friza13 friza13 reopened this Jul 19, 2026
@friza13 friza13 closed this Jul 19, 2026
@friza13 friza13 reopened this Jul 19, 2026
@github-actions github-actions Bot removed the Test links missing No test links from Online Editor provided label Jul 19, 2026
@github-actions

Copy link
Copy Markdown

PR Description Check Passed

All required sections are filled in correctly.

Details
  OK  Type of change: 1/4 checkboxes ticked
  OK  How Has This Been Tested?: all 3 checkboxes ticked
  OK  Checklist of common problems: 8/10 checkboxes ticked
  OK  Online Editor test results: 1 link(s) found
  OK  Template coverage: all 1 template(s) covered
Labels to remove: Checklist of common problems not complete, Forged editor links, PR description incomplete, Test links missing

PR description check PASSED

@pawel-kow
pawel-kow added this pull request to the merge queue Jul 19, 2026
Merged via the queue into Domain-Connect:master with commit 65afd11 Jul 19, 2026
22 of 27 checks passed
@github-actions

Copy link
Copy Markdown

Thanks @friza13 for contributing to the template. 🎉

This template has been reviewed and merged by @pawel-kow. 🙌

This template repository and its review process are maintained by independent individuals in their spare time, not as part of a paid role. If you or your company benefit from this protocol and its tools, please show your appreciation by buying a beer for @pawel-kow: https://github.com/sponsors/pawel-kow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hostRequired hostRequired is set

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants