add Grok, App Builder (subdomain + apex)#1389
Draft
shamwow wants to merge 3 commits into
Draft
Conversation
|
✅ JSON Filename Check Passed |
|
✅ JSON Schema Validation Passed |
Linter OK
|
| Level | Code | Note |
|---|
grok.com.app-builder.json
| Level | Code | Note |
|---|
PR Description Check FailedThe PR description is missing required elements. Please update it according to the PR template. Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two Domain Connect templates for Grok — App Builder (
grok.com), pointing acustomer's custom domain at an app deployed with Grok App Builder (Vercel-backed):
grok.com.app-builder.json— subdomain (e.g.app.example.com):CNAME → %vercelcname%,hostRequired.grok.com.app-builder-apex.json— apex (e.g.example.com):A → %vercelapex%.Routing targets are Vercel's per-project values (CNAME target / apex IP), which vary per
app — so they're template variables supplied at apply time and protected by a signed
synchronous request (
syncPubKeyDomain = domainconnect.grok.com,key = _dck1, RS256).Type of change
How Has This Been Tested?
<providerId>.<serviceId>.jsonlogoUrlis actually served (https://grok.com/images/favicon.svg,image/svg+xml)Both templates pass
dc-template-linter -loglevel error -tolerate info -logos(exit 0).Checklist of common problems (applies to both templates)
syncPubKeyDomainis set —domainconnect.grok.comwarnPhishingis not set alongsidesyncPubKeyDomainsyncRedirectDomainis set (grok.com) — sync flow usesredirect_uritxtConflictMatchingMode— n/a (no TXT records)pointsTovariable MUST be the only content (prefixes/suffixes forbidden), so the CNAME/A targets are bare variables by design; integrity is protected by the request signaturehostlabel — host is@hostfield to create a subdomain — subdomain template uses thehostparam +hostRequired%host%does not appear explicitly in anyhostattributeessential— n/aNotes:
_vercel,vc-domain-verify=<domain>,<token>) is intentionally not templated: it's conditional (only when the domain is already claimed on Vercel), zone-scoped, and dynamic — handled out-of-band.Online Editor test results
Editor test link(s):
hostset) — pending pastehostempty) — pending paste