feat(helix): drain alignment queue — story floor, JSON backbone, FR-23 closeout - #12
Merged
Merged
Conversation
…3 closeout Close the HELIX desired-state alignment epic against main after the spec/bead surgery landed: - Close shipped FEAT-034 beads (config, provision, manifest, diagnostics, CFG-02, optional degrade) with evidence from PR #10. - Author story-floor US-040/042/043/050 with ACs citing existing tests. - Implement JSON kind on the e2e backbone (Spark + DuckDB load paths). - Add FR-23 unit whole-stack composition test; update e2e-framework slot. - Link US-046 ACs via @Covers; evidence/waive residual US-045 ACs. - Update FEAT-031/032, PRD FR-21.7, feature registry, and test plan.
generate_pyspark_schema used datetime.now() when source_file_modified was absent, so two compile passes a second apart produced different artifacts and flaked test_candidate_mode_does_not_change_generated_runtime_artifacts in CI. Match DDL: omit the timestamp line unless metadata supplies it.
This was referenced Jul 23, 2026
dmautz1
pushed a commit
to dmautz1/tablespec
that referenced
this pull request
Jul 24, 2026
Alignment review after beads queue drain (DocumentDrivenDX#12/DocumentDrivenDX#13). Notes PR DocumentDrivenDX#14 as in-flight plan-to-code for FEAT-034/US-044 and bulk citation hygiene. Agent-executable follow-ups only: - @Covers US-037-AC1..5 on test_safe_timestamp (+ Connect sail) - @Covers US-038-AC1..5 on Playwright + pages artifact tests No beads filed for workspace-only residual (live app deploy, FM API job).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drains the HELIX desired-state alignment epic (
tablespec-263a0248) against currentmainafter the spec/bead surgery and FEAT-034 app work landed._declared_source+ Spark/DuckDB_load_rawacceptkind=json(projection viaJsonReader/read_json_auto).apps/data-profiling/tests/test_fr23_stack.py; concerns + test-plan updated.@covers+ AC evidence; US-045 residual ACs evidenced with explicit CI/workspace limitations.Test plan
uv run pytest apps/data-profiling/tests/ tests/unit/test_ingestion_package.py tests/unit/test_guidebook_generate.py tests/unit/test_guidebook_renderer.py tests/docs/ -q(401 passed)Out of scope (still open)
tablespec-ed74497cand children) —execution-eligible: false/ needs refinementtablespec-dbf90b8d)