Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #444
문제
컬렉션 삭제 확인창이 "하위 컬렉션과 그 안의 문서도 전부 함께 삭제됩니다"라고 안내했지만, 삭제 API(
CollectionCommandService.deleteCollection)는 컬렉션과 하위 컬렉션을 soft delete하고 문서 연결(collection_documents)·컬렉션 권한·closure 행만 지웁니다. 문서 자체는 상태와deleted_at이 바뀌지 않아 문서 목록에 그대로 남습니다.기능명세서 시험항목(2. 컬렉션 삭제)의 기대 결과도 "문서는 삭제되지 않고 문서 목록에 그대로 남는다"여서, 시험 중 확인창 안내와 실제 결과가 어긋났습니다.
변경
frontend/app/features/CollectionsPage.tsx확인창 문구를 실제 동작에 맞췄습니다.검증
npm run lintnpm test(빌드 포함)브라우저에서 확인창을 직접 띄워 확인하지는 않았습니다.
범위와 한계
PERMISSION_DENIED로 거부)는 이번 범위가 아닙니다.docs/design/kangcheolung-#229-collection-tree.md의 옛 문구 인용은 당시 설계 기록이라 그대로 둡니다.