Skip to content

fix: restore mobile navigation build after icon key refactor - #4

Merged
DoMinhHHung merged 1 commit into
mainfrom
fix/mobile-navigation-icon-build
Aug 7, 2026
Merged

fix: restore mobile navigation build after icon key refactor#4
DoMinhHHung merged 1 commit into
mainfrom
fix/mobile-navigation-icon-build

Conversation

@DoMinhHHung

@DoMinhHHung DoMinhHHung commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • map mobile navigation icon keys to Lucide components
  • preserve existing mobile sheet close behavior, route state, styling, and accessibility
  • fix the Next.js/TypeScript build failure where "dashboard" was treated as a JSX intrinsic element

Root cause

Commit 76caa8e changed AppNavigationItem.icon from a Lucide component to the string union key "dashboard" and updated the desktop navigation link mapping, but mobile-app-navigation.tsx still rendered item.icon directly as <Icon />.

Scope

Only src/components/layout/mobile-app-navigation.tsx changes.

Validation

  • source diff is one file / one focused commit
  • Vercel/CI build pending on this PR

No backend, auth, route, environment, or deployment configuration changes.

Summary by CodeRabbit

  • Cải tiến giao diện
    • Cập nhật biểu tượng trên thanh điều hướng để hiển thị nhất quán hơn.
    • Bổ sung và cấu hình biểu tượng cho mục Trang tổng quan.
    • Cải thiện khả năng hiển thị biểu tượng theo từng mục điều hướng.

@vercel

vercel Bot commented Aug 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bridge-works-apps Ready Ready Preview Aug 7, 2026 3:36am

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c83b7f12-1c5f-49ed-a3b3-ce6bef5e9c52

📥 Commits

Reviewing files that changed from the base of the PR and between 76caa8e and 07cbcbc.

📒 Files selected for processing (1)
  • src/components/layout/mobile-app-navigation.tsx

📝 Walkthrough

Walkthrough

Component điều hướng mobile thêm ánh xạ navigationIcons. Ánh xạ liên kết loại biểu tượng với component Lucide có kiểm tra kiểu. Luồng render tra cứu biểu tượng qua ánh xạ này.

Changes

Điều hướng mobile

Layer / File(s) Summary
Định nghĩa và sử dụng ánh xạ biểu tượng
src/components/layout/mobile-app-navigation.tsx
Thêm kiểu AppNavigationItem, ánh xạ dashboard tới LayoutDashboard, và dùng navigationIcons[item.icon] khi render.

Estimated code review effort: 2 (Đơn giản) | ~5 phút

Poem

Thỏ con thấy biểu tượng sáng,
Dashboard hiện nét dịu dàng.
Ánh xạ chạy đúng đường,
Lucide góp sắc vương,
Điều hướng nhẹ nhàng.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/mobile-navigation-icon-build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DoMinhHHung
DoMinhHHung marked this pull request as ready for review August 7, 2026 03:42
@DoMinhHHung
DoMinhHHung merged commit 840b488 into main Aug 7, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant