fix(enums): swap SubscriptionStatus.ending/.inactive values#1544
Open
shiftinv wants to merge 2 commits into
Open
fix(enums): swap SubscriptionStatus.ending/.inactive values#1544shiftinv wants to merge 2 commits into
SubscriptionStatus.ending/.inactive values#1544shiftinv wants to merge 2 commits into
Conversation
Contributor
|
Wow breaking change, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
These were incorrectly documented in the API docs as
ending = 1andinactive = 2, but are meant to be the other way around. Somehow no-one had noticed this (including me while testing back then) up until now c:https://github.com/discord/discord-api-docs/pull/8388/changes?w=1
Checklist
uv run nox -s lintuv run nox -s pyright