test: cover ThemeContext system-preference change listener#608
Open
Truphile wants to merge 2 commits into
Open
test: cover ThemeContext system-preference change listener#608Truphile wants to merge 2 commits into
Truphile wants to merge 2 commits into
Conversation
|
@Truphile Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have successfully completed the tasks to add tests for the OS-preference change listener in ThemeContext.tsx .
Here's a summary of the actions taken:
src/context/tests/ThemeContext.test.tsx , which was causing vitest to fail. I replaced these occurrences
with vi.fn() .
changes, stopping the listener when manually switched, and resuming when system preference is reselected). I
extended the test suite by adding an unmount test to verify that the removeEventListener is correctly called,
ensuring no memory leaks or unexpected updates occur.
pass cleanly.
listener per your instructions.
closes #328