Event-based geocoding for DT location fields#204
Open
jlamanskygitt wants to merge 5 commits into
Open
Conversation
✅ Deploy Preview for jade-chebakia-17493f ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Comment on lines
+107
to
+121
| if (!el.dataset.eventDtGeocode) { | ||
| el.addEventListener( | ||
| 'dt:geocode', | ||
| this.handleGeocodeEvent.bind(this) | ||
| ); | ||
| el.dataset.eventDtGeocode = true; | ||
| } | ||
|
|
||
| if (el.googleToken && !this.googleGeocodeService) { | ||
| this.googleGeocodeService = new GoogleGeocodeService( | ||
| el.googleToken, | ||
| window, | ||
| document, | ||
| ); | ||
| } |
Collaborator
There was a problem hiding this comment.
This will cause all of the other components with load events to also have geocode event handlers. That's not what we want. Tags, connections, etc., don't need to handle geocode events.
Instead of having this in the attachLoadEvents function, we should create a new function just to attachGeocodeEvents. Similar to the file upload function, this geocoding is separate from the load events but the function can be called in the initialize function.
Contributor
Author
There was a problem hiding this comment.
Thank you, that makes sense! I created attachGeocodeEvents() and moved the logic there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switched to event-based geocoding for DT location map. Resolves #203