fix(autofmt): stop dx fmt --all-code from duplicating and truncating … - #5816
Open
chairulakmal wants to merge 1 commit into
Open
fix(autofmt): stop dx fmt --all-code from duplicating and truncating …#5816chairulakmal wants to merge 1 commit into
chairulakmal wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…closure bodies
Fixes #5682.
dx fmt --all-coderuns the file through prettyplease before formatting thersx!bodies, and prettyplease often wraps a closure in the middle of its signature.write_partial_exprthen reads the wrapped line as a hand-written method chain, copies it out verbatim, and re-emits the lines after it, so the closure body comes out duplicated and truncated and the file no longer compiles.This narrows that part of the code to only take over when the source it copied matches the formatter output it replaces exactly.
Swept over every
.rsfile inexamples/andpackages/: plaindx fmtoutput does not change, and the 24 files that--all-codecorrupts today (20 of them into textsyncannot parse) all format cleanly with this change.