feat: support to disable auto open browser#365
Open
patrickmen wants to merge 1 commit into
Open
Conversation
patrickmen
force-pushed
the
feat/no-browser
branch
from
a95722e to
123f8af
Compare
Bububuger
approved these changes
May 28, 2026
Bububuger
left a comment
Bububuger
left a comment
There was a problem hiding this comment.
LGTM — clean fix wiring the existing --no-browser flag into device flow logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
dingtalk-workspace-cli/internal/app/auth_command.go
Line 182 in 5ce7cb6
The --no-browser flag was already defined on dws auth login but never wired to the device flow logic — the browser always opened regardless.
Fix