feat: Add Charity Commission API scraper and unit tests#71
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new scraper module for the Charity Commission for England and Wales “Register of Charities” API, including a small client wrapper, a higher-level scrape() orchestrator, and corresponding unit tests, plus an example raw output JSON.
Changes:
- Introduce
CharityCommissionAPIwith retry/backoff, API key handling, and endpoint helpers for common charity detail endpoints. - Add unit tests covering happy-path responses, 404 handling, and end-to-end
scrape()behavior with mocks. - Add a checked-in sample
register_of_charities_results.jsonoutput file undersrc/data/raw.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/scrapers/register_of_charities.py | New Charity Commission API client + scraping orchestration + CLI entrypoint. |
| src/tests/test_register_of_charities.py | Unit tests for the new scraper/client behaviors using mocked HTTP calls. |
| src/data/raw/register_of_charities_results.json | Example raw output produced by the new scraper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.