Skip to content

v2.29 CI JSON Output Fix #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DigiEmu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

v2.29 CI JSON Output Fix #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/vsc-conformance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,9 @@ jobs:
- name: Validate fixture comparison JSON
shell: bash
run: |
npm run vsc -- compare:fixtures --json > comparison-result.json
cat comparison-result.json
node src/vscCli.js compare:fixtures --json > comparison-result.json
head -n 5 comparison-result.json
node -e "const fs=require('fs'); JSON.parse(fs.readFileSync('comparison-result.json','utf8')); console.log('comparison-result.json is valid JSON')"
node -e "const fs = require('fs'); const data = JSON.parse(fs.readFileSync('comparison-result.json', 'utf8')); if (data.result !== 'COMPARE_PASS') { console.error(data); process.exit(1); } console.log('COMPARE_JSON_PASS');"

- name: Run full VSC verification
Expand Down
3 changes: 2 additions & 1 deletion src/vscCli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,8 @@ Use: npm run vsc -- restore-delta <base-token.json> <delta-token.json>
case "compare:fixtures": {
// v2.8.1 conformance comparison runner.
// Reads v2.7 fixture index and compares Go verifier --json output against expected results.
run("scripts/compareConformanceResults.js");
// Forward remaining args (e.g. --json) so the runner can switch output mode.
run("scripts/compareConformanceResults.js", args.slice(1));
break;
}

Expand Down
Loading