Fix tests when running with workflows=3.7#308
Merged
Merged
Conversation
workflows 3.7's start_transport() reads config._opentelemetry and, if truthy, constructs an OTLPSpanExporter. Because the test fixture uses a MagicMock for the configuration, that attribute was a truthy MagicMock and the exporter blew up on urlparse(MagicMock). Force it to None so the OTEL path is skipped.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #308 +/- ##
=======================================
Coverage 81.51% 81.51%
=======================================
Files 31 31
Lines 5697 5697
Branches 324 324
=======================================
Hits 4644 4644
Misses 983 983
Partials 70 70 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This constructed an always-truthy mock, which inadvertantly activated the OTEL pathways.