feat(yaml): adds a hera version of the example.yaml template from workflows#13
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 22 22
=========================================
Hits 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
e9baea7 to
f31d588
Compare
| kind: Workflow | ||
| metadata: | ||
| generateName: hera-example- | ||
| namespace: ks10000-3 |
There was a problem hiding this comment.
suggestion: best to avoid surfacing ks10000 developer test namespaces in user facing documentation if possible
| valueFrom: | ||
| path: /tmp/parameters.json | ||
| script: | ||
| image: python:3.10 |
There was a problem hiding this comment.
suggestion: python:3.10 is almost end of life. user facing examples should have more up to date version if possible
| - name: install-dependencies | ||
| script: | ||
| image: python:3.10 | ||
| source: |- |
There was a problem hiding this comment.
comment for the future, not for this PR: I know that you are doing this because you are re-implementing the example template that does this. I think that if this repo is going to model best user practices for Analysis Platform using pythonistas, we want to encourage building dependencies into the container itself. Installing dependencies in workflow steps is bad practice.
| from hera.workflows.archive import NoneArchiveStrategy | ||
|
|
||
| global_config.host = "https://argo-workflows.staging.workflows.diamond.ac.uk/" | ||
| global_config.token = "" |
There was a problem hiding this comment.
I guess this is supposed to be the Bearer token to let hera submit to Argo Workflows server? how is a user intended to use this?
| from hera.workflows import models as m | ||
| from hera.workflows.archive import NoneArchiveStrategy | ||
|
|
||
| global_config.host = "https://argo-workflows.staging.workflows.diamond.ac.uk/" |
There was a problem hiding this comment.
comment for future direction: This submits directly via the Argo Workflows server.
It would be better if we have a model where users submit via the graph.
| @@ -0,0 +1,215 @@ | |||
| apiVersion: argoproj.io/v1alpha1 | |||
There was a problem hiding this comment.
Is it intentional that a generated Workflow yaml (i.e. not a ClusterWorkflowTemplate) is committed to the repo?
2 participants
Here's the result of the workflow being ran:
https://staging.workflows.diamond.ac.uk/workflows/ks10000-3/hera-example-bhk5k