Skip to content

I19-2 new eiger serial test fixes#406

Merged
noemifrisina merged 3 commits into
mainfrom
beamline-fixes
Jul 6, 2026
Merged

I19-2 new eiger serial test fixes#406
noemifrisina merged 3 commits into
mainfrom
beamline-fixes

Conversation

@noemifrisina

@noemifrisina noemifrisina commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Closes #405

@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.75%. Comparing base (a769650) to head (4501e48).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/nexgen/beamlines/i19_2/eiger.py 0.00% 1 Missing ⚠️
src/nexgen/nxs_write/nxclass_writers.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
+ Coverage   44.75%   45.75%   +1.00%     
==========================================
  Files          53       53              
  Lines        4326     4336      +10     
  Branches      558      559       +1     
==========================================
+ Hits         1936     1984      +48     
+ Misses       2272     2231      -41     
- Partials      118      121       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@noemifrisina
noemifrisina merged commit 9fce8e5 into main Jul 6, 2026
15 checks passed
@noemifrisina
noemifrisina deleted the beamline-fixes branch July 6, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix the detector specific fields in NXcollection for new eiger

1 participant