Improve the PR template#1785
Conversation
1a31e14 to
b5711f0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1785 +/- ##
=======================================
Coverage 93.03% 93.03%
=======================================
Files 164 164
Lines 8931 8931
=======================================
Hits 8309 8309
Misses 622 622
🚀 New features to boost your workflow:
|
| Fixes #ISSUE | ||
| Fixes: | ||
|
|
||
| * #ISSUE |
There was a problem hiding this comment.
Obviously up to you on how you want to run your workflow but this will mean that you no longer get tickets auto-closed when related PRs are merged but maybe that's deliberate?
There was a problem hiding this comment.
TBH I hadn't realised that was a side-effect of this change - I've been deliberately reformatting my PRs for ages like this, and had never noticed it.
There was a problem hiding this comment.
Seems like I can either have nice formatting via tasklists, or have auto-linked issues but not both? That's a bit pants.
I think I would rather have the nicer formatting, sometimes I have multiple PRs relating to a single issue but only the last of them fixes it.
Not sure I can be bothered to create a github action to get this functionality back, which might be a possibility of having my cake and eating it.
Fixes:
Requires:
(remember to update
pyproject.tomlwith the dodal commit tag if you need it for tests to pass!)Updates the PR template from the existing one to give better guidance for submitters and reviewers
Specific advice for testing, if any
PR Checklist