Added new move on click plan#1637
Open
adaudon wants to merge 4 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1637 +/- ##
=======================================
Coverage 93.08% 93.08%
=======================================
Files 164 164
Lines 8989 8997 +8
=======================================
+ Hits 8367 8375 +8
Misses 622 622
🚀 New features to boost your workflow:
|
noemifrisina
requested changes
Mar 3, 2026
noemifrisina
left a comment
noemifrisina
left a comment
Contributor
There was a problem hiding this comment.
Thanks, a couple of things to do...
I think we may need to run this on the beamline to be totally sure it does the same as the old one
adaudon
force-pushed
the
ui86-move_on_click
branch
5 times, most recently
from
March 10, 2026 16:50
069450e to
83199cc
Compare
adaudon
force-pushed
the
ui86-move_on_click
branch
from
March 30, 2026 10:17
9074afc to
80c0b04
Compare
adaudon
enabled auto-merge (squash)
April 10, 2026 10:30
rtuck99
reviewed
Jul 16, 2026
| def test_move_on_oav_view_click( | ||
| coordinates, expected_x, expected_y, oav, pmac, run_engine | ||
| ): | ||
| def fake_rd(_signal): |
Contributor
There was a problem hiding this comment.
Would be nice to parametrize here on a couple of different values of microns per pixel x/y just to ensure that the calculation does actually use them correctly
rtuck99
approved these changes
Jul 16, 2026
rtuck99
left a comment
rtuck99
left a comment
Contributor
There was a problem hiding this comment.
Looks good, only one minor comment, take it or leave it
adaudon
force-pushed
the
ui86-move_on_click
branch
from
July 17, 2026 16:04
f7817ee to
6df88a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DiamondLightSource/mx-daq-ui#86
Instructions to reviewer on how to test:
Checks for reviewer