Pin daq config server#2127
Merged
Merged
Conversation
rtuck99
marked this pull request as ready for review
July 21, 2026 10:28
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2127 +/- ##
=======================================
Coverage 99.15% 99.15%
=======================================
Files 353 353
Lines 13793 13793
=======================================
Hits 13677 13677
Misses 116 116 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
oliwenmandiamond
approved these changes
Jul 21, 2026
| "scanspec>=0.7.3", | ||
| "pyzmq==27.1.0", | ||
| "deepdiff", | ||
| "daq-config-server >= 1.3.6", # For getting Configuration settings. |
Contributor
There was a problem hiding this comment.
"daq-config-server == 1.3.6",
Wouldn't this be simpler?
CoePaul
approved these changes
Jul 21, 2026
CoePaul
left a comment
CoePaul
left a comment
Contributor
There was a problem hiding this comment.
Valid and internally consistent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins daq-config-server to < 1.4.0 while
is yet to be merged, following release of daq-config-server which contains
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}