Skip to content

Update for daq config server 1.4#2126

Closed
rtuck99 wants to merge 6 commits into
mainfrom
update_for_daq_config_server_1.4
Closed

Update for daq config server 1.4#2126
rtuck99 wants to merge 6 commits into
mainfrom
update_for_daq_config_server_1.4

Conversation

@rtuck99

@rtuck99 rtuck99 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Fixes dodal following changes to daq-config-server that removed the ConfigClient from the base package __all__

This explicitly does not use the new mocking facility in the daq-config-server client; this update is merely in order to allow dodal to build and release successfully.

Instructions to reviewer on how to test:

  1. Tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@oliwenmandiamond

oliwenmandiamond commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Hey @rtuck99, I think you can close this. I have updated #2099 to use the new version anyway

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.15%. Comparing base (db980cb) to head (cfa8087).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2126   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files         353      353           
  Lines       13793    13793           
=======================================
  Hits        13677    13677           
  Misses        116      116           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rtuck99 rtuck99 closed this Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants