Add i06-1 magnets#2115
Open
oliwenmandiamond wants to merge 35 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2115 +/- ##
==========================================
+ Coverage 99.15% 99.17% +0.01%
==========================================
Files 349 354 +5
Lines 13681 13985 +304
==========================================
+ Hits 13565 13869 +304
Misses 116 116 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…/dodal into add_i06_magnets
Relm-Arrowny
left a comment
Contributor
There was a problem hiding this comment.
I gone through it roughly, I have a few questions
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2120
Instructions to reviewer on how to test:
dodal connect i06-1Checks for reviewer
dodal connect ${BEAMLINE}