Skip to content

Add i09-2 stage using StandardMovable#2093

Merged
oliwenmandiamond merged 37 commits into
mainfrom
add_i09_2_stage
Jul 16, 2026
Merged

Add i09-2 stage using StandardMovable#2093
oliwenmandiamond merged 37 commits into
mainfrom
add_i09_2_stage

Conversation

@oliwenmandiamond

@oliwenmandiamond oliwenmandiamond commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Fixes #2107

Instructions to reviewer on how to test:

  1. Check implementation makes sense
  2. Refactor of existing logic is okay
  3. Tests pass
  4. dodal connect works for i09-2

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.15%. Comparing base (c8aa742) to head (bd374a7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2093   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files         349      352    +3     
  Lines       13681    13725   +44     
=======================================
+ Hits        13565    13609   +44     
  Misses        116      116           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oliwenmandiamond
oliwenmandiamond marked this pull request as ready for review June 25, 2026 08:18
@oliwenmandiamond
oliwenmandiamond requested a review from a team as a code owner June 25, 2026 08:18
@oliwenmandiamond oliwenmandiamond changed the title Add i09 2 stage using StandardMovable Add i09-2 stage using StandardMovable Jun 25, 2026
@Relm-Arrowny Relm-Arrowny self-assigned this Jun 26, 2026

@Relm-Arrowny Relm-Arrowny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things.

Comment thread src/dodal/devices/movable.py Outdated
Comment thread src/dodal/devices/beamlines/i09_2/i09_2_motors.py Outdated
Comment thread src/dodal/devices/beamlines/i09_2/i09_2_motors.py
Comment thread tests/devices/test_movable.py Outdated

@Relm-Arrowny Relm-Arrowny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last thing.

Comment thread src/dodal/devices/movable.py Outdated

@Relm-Arrowny Relm-Arrowny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

Comment thread tests/devices/test_movable.py Outdated
@oliwenmandiamond
oliwenmandiamond enabled auto-merge (squash) July 16, 2026 08:42
@oliwenmandiamond
oliwenmandiamond merged commit 0e7c63f into main Jul 16, 2026
11 checks passed
@oliwenmandiamond
oliwenmandiamond deleted the add_i09_2_stage branch July 16, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add I09-2 sample stage

2 participants