Change to QThread#37
Open
M-Chan wants to merge 18 commits into
Open
Conversation
JamesOHeaDLS
requested changes
Jul 14, 2026
Comment on lines
+47
to
+59
| self.lock = ( | ||
| threading.Lock() | ||
| ) # Use lock to prevent race condition for watch window | ||
|
|
||
| # Give thread own Qt event loop | ||
| # polling every 100ms and slots excute when signals come | ||
| def start(self): | ||
| self.timer = QTimer(self) | ||
| self.timer.timeout.connect(self.update_func) | ||
| self.timer.start(100) | ||
|
|
||
| def stop(self): | ||
| if hasattr(self, "timer"): |
Contributor
There was a problem hiding this comment.
I don't think hasattr is needed here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to QThread with new python file comms_qtthread
Still using Custom events but this will later be removed in favour of a more QT-style way of working
Physical test connecting to Lab18's Geobricks 2/3 working
Motor test is failing