Skip to content

Nl/add image to bool button #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NatLeung96 merged 2 commits into from
Jul 21, 2026
Merged

Nl/add image to bool button #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f91fd98
add onImage and offImage to bobParser
NatLeung96 Jul 16, 2026
2364561
add on/off image to boolButton
NatLeung96 Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 30 additions & 11 deletions src/ui/widgets/BoolButton/boolButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,9 @@ const BoolButtonProps = {
enabled: BoolPropOpt,
font: FontPropOpt,
textAlign: ChoicePropOpt(["left", "center", "right"]),
textAlignV: ChoicePropOpt(["top", "center", "bottom"])
textAlignV: ChoicePropOpt(["top", "center", "bottom"]),
onImage: StringPropOpt,
offImage: StringPropOpt
};

const Button = styled(MuiButton)({
Expand Down Expand Up @@ -102,7 +104,9 @@ export const BoolButtonComponent = (
labelsFromPv = false,
enabled = true,
textAlign = "center",
textAlignV = "center"
textAlignV = "center",
onImage,
offImage
} = newProps as BoolButtonComponentProps;
const {
value,
Expand Down Expand Up @@ -132,6 +136,7 @@ export const BoolButtonComponent = (
const [label, setLabel] = useState(showBooleanLabel ? offLabel : "");
const doubleValue = dTypeGetDoubleValue(value);
const [ledColor, setLedColor] = useState(style?.customColors?.offColor);
const [imageFileName, setImageFileName] = useState(offImage);

// Establish LED style
const ledDiameter = showLed ? getDimensions(size.width, size.height) : 0;
Expand All @@ -143,9 +148,11 @@ export const BoolButtonComponent = (
useEffect(() => {
if (doubleValue === onState) {
if (showBooleanLabel) setLabel(onLabel);
setImageFileName(onImage);
setLedColor(style?.customColors?.onColor);
} else if (doubleValue === offState) {
if (showBooleanLabel) setLabel(offLabel);
setImageFileName(offImage);
setLedColor(style?.customColors?.offColor);
}
}, [
Expand All @@ -156,7 +163,9 @@ export const BoolButtonComponent = (
style?.customColors?.onColor,
offState,
offLabel,
showBooleanLabel
showBooleanLabel,
onImage,
offImage
]);

function handleClick() {
Expand Down Expand Up @@ -194,19 +203,29 @@ export const BoolButtonComponent = (
}
}}
startIcon={
showLed ? (
<div
style={{ width: `${ledDiameter}px`, height: `${ledDiameter}px` }}
>
<div
style={{ width: `${ledDiameter}px`, height: `${ledDiameter}px` }}
>
{imageFileName ? (
<img
src={imageFileName}
alt=""
style={{
objectFit: "contain",
height: "100%",
width: "100%"
}}
/>
) : showLed ? (
<LedComponent
pvData={pvData}
onColor={newColor(style?.customColors?.onColor)}
offColor={newColor(style?.customColors?.offColor)}
/>
</div>
) : (
<></>
)
) : (
<></>
)}
</div>
}
>
{label}
Expand Down
4 changes: 3 additions & 1 deletion src/ui/widgets/EmbeddedDisplay/bobParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,7 +677,9 @@ export const BOB_SIMPLE_PARSERS: ParserDict = {
tabHeight: ["tab_height", bobParseNumber],
tabSpacing: ["tab_spacing", bobParseNumber],
activeTab: ["active_tab", bobParseNumber],
editable: ["editable", opiParseBoolean]
editable: ["editable", opiParseBoolean],
onImage: ["on_image", opiParseString],
offImage: ["off_image", opiParseString]
};

export const BOB_COMPLEX_PARSERS: ComplexParserDict = {
Expand Down
Loading