Repository navigation
feat: guard library against wrong mounts - #1055
Merged
Merged
Conversation
When the downloads folder points somewhere other than the library (for
example after the library was moved on the host but the volume line
was not), the empty-folder check stopped protecting it once a single
download landed in that folder. After that, rescans could mark every
video missing and Empty trash offered to forget them. On slow shares,
rescans could also stop at the 5-minute limit right after the disk
walk, so each run started over and never finished.
- Rescans always finish the walk and the row check; the time limit
now covers only resolution probing and starts after the walk
- Rescans log walk progress and hold back missing marks in a folder
where fewer than half of its videos (and at least 25) were found
- Other writers also sample 20 stored paths and treat the folder as
unavailable ("not-found") when most of them are gone
- Downloads pause while the downloads folder looks unavailable; that
check is cached, runs one at a time and has a timeout
- Rescan anyway shows how many videos it would mark missing and needs
a checkbox; Empty trash no longer preselects Missing, and both trash
actions ask again when most of the library is missing
- Maintenance shows live rescan progress, files found next to videos
in the database, run length and the missing count
- Settings no longer says YOUTUBE_OUTPUT_DIR sets the volume
Refs: #1054
Contributor
📊 Test Coverage ReportBackend Coverage
Frontend Coverage
Coverage Requirements
Coverage report generated for commit 5a97254 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the downloads folder points somewhere other than the library (for example after the library was moved on the host but the volume line was not), the empty-folder check stopped protecting it once a single download landed in that folder. After that, rescans could mark every video missing and Empty trash offered to forget them. On slow shares, rescans could also stop at the 5-minute limit right after the disk walk, so each run started over and never finished.
Refs: #1054