Repository navigation
chore(agents): adopt the shared Rust style and test skills - #576
Merged
Benoît Cortier (CBenoit) merged 12 commits intoOct 21, 2026
Merged
Conversation
The rust-style-reviewer skill opens STYLE.md when a rule's intent is unclear. Pin the IronRDP guide at a known revision so the reference is local and stable, with a header noting which sections describe IronRDP's PDU crates rather than picky-rs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Mirror rust-style, rust-style-reviewer, test-oracle-reviewer and test-pruner from Devolutions Gateway so agents apply the shared Rust conventions while writing code, review style on changed lines, and judge or prune tests with oracle and mutation evidence. The skills are added to the weekly sync list and copied verbatim now. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
AGENTS.md now points Rust edits at the rust-style skill, and the code-review skill runs rust-style-reviewer on changed Rust lines in parallel with the other focused passes. STYLE.md stays reachable only through the reviewer so agents do not load the full guide on every edit. The INVARIANT rules move to rust-style, leaving the UNTESTED guidance here, and the intent-file rules use the same prose form as the other Devolutions repositories. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Open with where skills live and which ones the weekly sync overwrites, add the expect-with-reason and typed-error rules, and point at the nested picky-crypto instructions. Drop sentences that rust-style and prose-writer already state, along with the pointer to rust-style-reviewer, which the code-review skill invokes itself. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Take the latest rust-style from Devolutions Gateway, which places test items at the end of the file and uses io::Result as the crate-qualified example, and note in commit-scope the cliff.toml footers that skip an entry or file it under Security. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Take the latest copies from Devolutions Gateway: the cargo-mutants notes no longer assume Gateway's package and testsuite layout, and the reviewer returns no findings when touched code follows the rules. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
Synchronization against the current upstream skill would propose removing newly adopted local requirements.
1 open issue
What changed in this PR
Adopts shared Rust-style and test-review skills for the repository’s agent workflows.
Changes:
- Adds four shared skills and enables weekly synchronization.
- Integrates Rust-style review and vendors a pinned style guide.
- Streamlines agent guidance and documents changelog footers.
| File | Description |
|---|---|
STYLE.md |
Vendors the full Rust style guide. |
AGENTS.md |
Updates repository guidance and skill references. |
.github/skills/code-review/SKILL.md |
Adds the Rust-style review pass. |
.github/skills-sync.yml |
Registers four shared skills. |
.agents/skills/test-pruner/SKILL.md |
Adds evidence-based test pruning guidance. |
.agents/skills/test-pruner/references/mutants.md |
Documents mutation-testing mechanics. |
.agents/skills/test-oracle-reviewer/SKILL.md |
Adds expected-value verification guidance. |
.agents/skills/rust-style/SKILL.md |
Defines Rust editing conventions. |
.agents/skills/rust-style-reviewer/SKILL.md |
Defines focused Rust-style review. |
.agents/skills/commit-scope/SKILL.md |
Documents changelog control footers. |
Review effort: Balanced
Take the latest copy from Devolutions Gateway so the reviewer also enforces rules stated in rust-style but absent from STYLE.md. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Add both Devolutions Gateway skills to the weekly sync list; the next sync run brings their directories. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Add 18 Devolutions Gateway skills to the weekly sync list: tdd and its intent closure, which the synced test skills depend on, the contribute flow with its contract, dependency and review skills, and the intent and skill authoring skills. The code-review skill now runs the intent, contract, test and dependency reviewers when their surfaces change, and AGENTS.md points test writing at test-writer. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Claude Code discovers project skills only under .claude/skills and reads only CLAUDE.md. Link .claude/skills to .agents/skills and add CLAUDE.md beside each nested AGENTS.md, matching the root link. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Point agents at the contribute skill first, which picks the delivery flow by scale and the skills each step needs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Agents load the nested AGENTS.md (or its CLAUDE.md link) when working in those crates, and picky-crypto-rustcrypto/AGENTS.md already limits backend tests to adapter logic, so the root pointer adds nothing. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Benoît Cortier (CBenoit)
deleted the
cbenoit-sync-gateway-agent-instructions
branch
October 21, 2026 18:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror the rust-style, rust-style-reviewer, test-oracle-reviewer and test-pruner skills from Devolutions Gateway, add them to the weekly skills sync, and vendor the IronRDP style guide as STYLE.md at a pinned revision so the reviewer can cite it locally.
AGENTS.md points Rust edits at rust-style, and the code-review skill runs rust-style-reviewer on changed Rust lines in parallel with the other focused passes. STYLE.md is reachable only through the reviewer, so agents do not load the full guide on every edit. The INVARIANT rules now live in rust-style, and the intent-file rules use the same prose form as the other Devolutions repositories.
AGENTS.md keeps only guidance an agent cannot infer: where skills live and which ones the weekly sync overwrites, the expect-with-reason rule for lint suppressions, and typed library errors without anyhow; rules already stated by rust-style and prose-writer are dropped. rust-style now places test items at the end of the file, and commit-scope documents the cliff.toml footers
Changelog: ignoreandSecurity: yes.The weekly sync also lists 18 more Gateway skills: tdd, grill-intent, intent-files and variants, which the synced test-writer and test-pruner depend on; the contribute flow with lead, orchestrate-effort, review-feedback-loop, contract-authoring, contract-review, blind-testsuite, dependency-pruner, dependency-reviewer, intent-drift-audit and intent-review; and agents-md, agents-md-review and skill-discipline for authoring agent instructions and skills. The code-review skill runs intent-drift-audit, intent-review, contract-review, test-reviewer and dependency-reviewer when the diff touches their surfaces, and AGENTS.md points test writing at test-writer.
Claude Code discovers project skills only under .claude/skills and reads only CLAUDE.md, so .claude/skills links to .agents/skills and each nested AGENTS.md under picky-crypto, picky-crypto-rustcrypto and picky-crypto-testsuite gains a CLAUDE.md link beside it, matching the root link.
AGENTS.md tells agents to start a work session with /contribute, which picks the delivery flow by scale and the skills each step needs.