Skip to content

Implemented .rubocop.yml to ignore certain metrics we don't care about #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aleksandergreg merged 1 commit into from
Jun 24, 2025
Merged

Implemented .rubocop.yml to ignore certain metrics we don't care about #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,11 @@ jobs:

- name: Auto-correct RuboCop issues
working-directory: sinatra
run: bundle exec rubocop -A || true
run: bundle exec rubocop -A

- name: Run RuboCop
working-directory: sinatra
run: bundle exec rubocop || true
run: bundle exec rubocop

# Job 3: Lint Dockerfiles
lint-docker:
Expand Down
26 changes: 26 additions & 0 deletions sinatra/.rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# Disable specific cops for the entire project
AllCops:
Exclude:
- 'db/schema.rb'
- 'vendor/**/*'
- 'node_modules/**/*'

# Ignore line length warnings
Layout/LineLength:
Enabled: false

# Ignore warnings about blocks being too long
Metrics/BlockLength:
Enabled: false

# Ignore warnings about methods being too long
Metrics/MethodLength:
Enabled: false

# Ignore warnings about assignment, branch, and condition size
Metrics/AbcSize:
Enabled: false

# Ignore warnings about classes being too long
Metrics/ClassLength:
Enabled: false
3 changes: 1 addition & 2 deletions sinatra/views/layout.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@

<div class="footer">
<span>DynaSearch 🧨 &copy; 2025</span>
<a href="/about">About</a>
<a href="/sla">SLA</a>
<a href="/about">About</a>
</div>
</div>
<%# Correct path for script located in public/js/search.js %>
Expand Down