Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues remain.
Review effort: Lite
Findings: None
What changed in this PR
Refactors focused-row update handling into FocusController while keeping DataGrid-specific keyboard navigation behavior local.
Changes:
- Moves
_updateFocusedRowIfNeededtoFocusController. - Removes the generic data-controller dependency.
- Adds keyboard-navigation access to the DataGrid focus extender.
| File | Description |
|---|---|
packages/devextreme/js/__internal/grids/grid_core/focus/m_focus.ts |
Owns focused-row update behavior in FocusController. |
packages/devextreme/js/__internal/grids/data_grid/focus/m_focus.ts |
Provides DataGrid-specific keyboard-navigation access. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the focused-row update logic out of the grid data controller and into the focus controller
How
Relocates the
_updateFocusedRowIfNeededmethod intoFocusControllerand moves the keyboard-navigation controller reference it relied on down into the DataGrid focus extender